Fixes #25 SerializableInterface maintains instances when set by Inspector #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2022
Thundernerd
approved these changes
Jul 22, 2022
Owner
Thundernerd
left a comment
Thundernerd
left a comment
There was a problem hiding this comment.
Thank you so much for all your work! It seems there's a merge conflict, so once that has been resolved I'll merge it :)
Thundernerd
approved these changes
Jul 22, 2022
Owner
Thundernerd
left a comment
Thundernerd
left a comment
There was a problem hiding this comment.
Wanted to merge this one as well, but unfortunately merge conflicts appeared again due to merging other PRs from you. Once resolved I'll merge it!
Once again, thank you for your work!
…Setter-ReferenceDrawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RawReferenceDrawer.RawReferenceValueto base classReferenceDrawer.PropertyValue) to correctly set and get value fromSerializableInterface.This fixes #25 and fixes and potential bug mentionned here